feat(ripple): add memo field to RippleSignTx for THORChain swap routing#110
Closed
BitHighlander wants to merge 1 commit into
Closed
feat(ripple): add memo field to RippleSignTx for THORChain swap routing#110BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
Collaborator
Author
|
Consolidating into a single comprehensive device-protocol PR covering the entire firmware release (not per-field). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
optional string memo = 7;toRippleSignTx.message RippleSignTx { optional RipplePayment payment = 6; // Payment transaction type + optional string memo = 7; // transaction memo (e.g. THORChain swap routing memo) }Why
XRP is a supported THORChain swap asset. THORChain routes swaps via a memo
string on the transaction; without a memo field the device cannot sign
XRP→THORChain swaps. This lets the host supply the routing memo for the device
to display and sign.
Wire compatibility
memois omitted.Downstream
Consumed by keepkey-firmware (memo display) and python-keepkey; staged to pin
once merged.